Skip to content

Update to ACK runtime v0.43.0, code-generator v0.43.1#17

Closed
ack-bot wants to merge 1 commit intomainfrom
ack-bot/rt-v0.43.0-codegen-v0.43.1
Closed

Update to ACK runtime v0.43.0, code-generator v0.43.1#17
ack-bot wants to merge 1 commit intomainfrom
ack-bot/rt-v0.43.0-codegen-v0.43.1

Conversation

@ack-bot
Copy link
Copy Markdown
Collaborator

@ack-bot ack-bot commented Feb 19, 2025

Update to ACK runtime v0.43.0, code-generator v0.43.1

NOTE:
This PR increments the release version of service controller from v1.0.4 to v1.0.5

Once this PR is merged, release v1.0.5 will be automatically created for recyclebin-controller

Please close this PR, if you do not want the new patch release for recyclebin-controller

stdout for make build-controller:

building ack-generate ... ok.
==== building recyclebin-controller ====
Copying common custom resource definitions into recyclebin
Building Kubernetes API objects for recyclebin
Generating deepcopy code for recyclebin
Generating custom resource definitions for recyclebin
Building service controller for recyclebin
Running GO mod tidy
Generating RBAC manifests for recyclebin
Running gofmt against generated code for recyclebin
Updating additional GitHub repository maintenance files
==== building recyclebin-controller release artifacts ====
Building release artifacts for recyclebin-v1.0.5
Generating common custom resource definitions
Generating custom resource definitions for recyclebin
Generating RBAC manifests for recyclebin

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot added the prow/auto-gen PRs related to prow auto generation automation label Feb 19, 2025
@ack-prow ack-prow bot requested review from a-hilaly and michaelhtm February 19, 2025 23:19
@ack-prow
Copy link
Copy Markdown

ack-prow bot commented Feb 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ack-bot
Once this PR has been reviewed and has the lgtm label, please assign a-hilaly for approval by writing /assign @a-hilaly in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot
Copy link
Copy Markdown
Collaborator Author

ack-bot commented Aug 19, 2025

Issues go stale after 180d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 60d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle stale

@ack-prow ack-prow bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 19, 2025
@ack-bot
Copy link
Copy Markdown
Collaborator Author

ack-bot commented Oct 18, 2025

Stale issues rot after 60d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 60d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle rotten

@ack-prow ack-prow bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 18, 2025
@ack-prow
Copy link
Copy Markdown

ack-prow bot commented Oct 30, 2025

@ack-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
recyclebin-verify-attribution 7608886 link false /test recyclebin-verify-attribution
recyclebin-kind-e2e 7608886 link true /test recyclebin-kind-e2e
recyclebin-unit-test 7608886 link true /test recyclebin-unit-test
recyclebin-recommended-policy-test 7608886 link true /test recyclebin-recommended-policy-test
recyclebin-metadata-file-test 7608886 link true /test recyclebin-metadata-file-test
recyclebin-release-test 7608886 link true /test recyclebin-release-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ack-bot
Copy link
Copy Markdown
Collaborator Author

ack-bot commented Dec 29, 2025

Rotten issues close after 60d of inactivity.
Reopen the issue with /reopen.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/close

@ack-prow ack-prow bot closed this Dec 29, 2025
@ack-prow
Copy link
Copy Markdown

ack-prow bot commented Dec 29, 2025

@ack-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 60d of inactivity.
Reopen the issue with /reopen.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@a-hilaly a-hilaly Awaiting requested review from a-hilaly

@michaelhtm michaelhtm Awaiting requested review from michaelhtm

Assignees

No one assigned

Labels

lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. prow/auto-gen PRs related to prow auto generation automation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ack-bot